Issue 5015005: Fix XSRF token in gcl so we don't need to hack rietveld anymore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5015005: Fix XSRF token in gcl so we don't need to hack rietveld anymore. (Closed)

Created:
10 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Fix XSRF token in gcl so we don't need to hack rietveld anymore. Improve SendToRietveld to hardcode less function arguments. TEST=manually tested that gcl works on both chromium and non-chromium rietveld instances BUG=none

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -6 lines)			Patch
	M	gcl.py	View		3 chunks	+16 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

The main side effect is that since the rietveld object is created three time, it ...

10 years, 1 month ago (2010-11-16 16:07:01 UTC) #1

lgtm

Expand Messages | Collapse Messages