Issue 5013003: chromeos: Add screen locker to window group *after* grab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5013003: chromeos: Add screen locker to window group after grab. (Closed)

Created:
10 years, 1 month ago by Daniel Erat

Modified:
9 years, 7 months ago

Reviewers:
oshima

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/browser/chromeos/login

Visibility:
Public.

Description

chromeos: Add screen locker to window group *after* grab. Otherwise, if it's already in its own window group, it won't be able to break other widgets' grabs. This also separates out the showing and grabbing code, so we can show the widget before mapping the locker window and then grab the pointer and keyboard afterwards. BUG=chromium-os:8999, chromium-os:9200 TEST=opened a context menu and checked that screen locks immediately. also tested that the original problem with modal dialogs didn't regress Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66287 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66460

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : show widget immediately but defer grab #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -14 lines)			Patch
	M	chrome/browser/chromeos/login/screen_locker.cc	View	1 2	4 chunks	+18 lines, -14 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

10 years, 1 month ago (2010-11-17 17:55:29 UTC) #5

Thanks!  I've merged r66287 and r66340 into 552d already.

On Wed, Nov 17, 2010 at 9:46 AM,  <oshima@chromium.org> wrote:
> Dan, I'm going to reland this.
>
> http://codereview.chromium.org/5013003/
>