Issue 5012005: Modify GetErrorDescription to give a -1004 on NETWORK_ACCESS_DENIED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5012005: Modify GetErrorDescription to give a -1004 on NETWORK_ACCESS_DENIED (Closed)

Created:
10 years, 1 month ago by mmenke

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Modify GetErrorDescription to give a -1004 (NSURLErrorCannotConnectToHost) when passed a net::ERR_NETWORK_ACCESS_DENIED error. This results in a error code being output by the security/block-test-no-port.html layout test on OSX that is consistent with other platforms. The test is also temporarily disabled on OSX until the expected results are updated. BUG=61655 TEST=security/block-test-no-port.html (Currently disabled) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66619

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Patch Set 4 : sync with trunk #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
M	webkit/support/webkit_support.cc	View	1 2 3	2 chunks	+3 lines, -2 lines	0 comments	Download
M	webkit/tools/layout_tests/test_expectations.txt	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	1 2 3	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mmenke

Figure you're the best to review this, since you've at least looked at the code ...

10 years, 1 month ago (2010-11-17 20:39:32 UTC) #1

wtc

10 years, 1 month ago (2010-11-17 22:08:30 UTC) #2

LGTM!  Thanks for fixing this.

http://codereview.chromium.org/5012005/diff/4001/webkit/support/webkit_suppor...
File webkit/support/webkit_support.cc (right):

http://codereview.chromium.org/5012005/diff/4001/webkit/support/webkit_suppor...
webkit/support/webkit_support.cc:467: // NSURLErrorCancelled
Nit: I'd prefer that you put these comments after the
Apple error codes, like this:
      code = -999;  // NSURLErrorCancelled

Expand Messages | Collapse Messages