Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2110)

Unified Diff: base/shared_memory_win.cc

Issue 5012001: Chrome Frame: Add explicit object security attributes to the Chrome Frame ver... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/shared_memory_win.cc
===================================================================
--- base/shared_memory_win.cc (revision 65236)
+++ base/shared_memory_win.cc (working copy)
@@ -197,17 +197,16 @@
}
void SharedMemory::Lock() {
- Lock(INFINITE);
+ Lock(INFINITE, NULL);
}
-bool SharedMemory::Lock(uint32 timeout_ms) {
+bool SharedMemory::Lock(uint32 timeout_ms, SECURITY_ATTRIBUTES* sec_attr) {
if (lock_ == NULL) {
std::wstring name = name_;
name.append(L"lock");
- lock_ = CreateMutex(NULL, FALSE, name.c_str());
- DCHECK(lock_ != NULL);
+ lock_ = CreateMutex(sec_attr, FALSE, name.c_str());
if (lock_ == NULL) {
- DLOG(ERROR) << "Could not create mutex" << GetLastError();
+ LOG(ERROR) << "Could not create mutex" << GetLastError();
tommi (sloooow) - chröme 2010/11/15 19:33:30 change this to PLOG (and remove the call to GLE)?
robertshield 2010/11/15 20:32:18 Done.
return false; // there is nothing good we can do here.
}
}
« no previous file with comments | « base/shared_memory.h ('k') | chrome_frame/module_utils.h » ('j') | chrome_frame/module_utils.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698