Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: net/socket/ssl_client_socket_nss.cc

Issue 501178: Linux: allow TLS renegotiation. (Closed)
Patch Set: Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket_nss.cc
diff --git a/net/socket/ssl_client_socket_nss.cc b/net/socket/ssl_client_socket_nss.cc
index c013ed8bc10f04b1c41db369d2048f8109c8438f..ed50e16099a6afa1aabb46d5331c0ff53c3bd486 100644
--- a/net/socket/ssl_client_socket_nss.cc
+++ b/net/socket/ssl_client_socket_nss.cc
@@ -314,6 +314,17 @@ int SSLClientSocketNSS::InitializeSSLOptions() {
LOG(INFO) << "SSL_ENABLE_DEFLATE failed. Old system nss?";
#endif
+#ifdef SSL_ENABLE_RENEGOTIATION
+ /* We allow servers to request renegotiation. Since we're a client,
wtc 2010/01/05 19:48:51 Please use C++ comment delimiter "//" because this
+ * prohibiting this is rather a waste of time. Only servers are in a position
+ * to prevent renegotiation attacks.
+ * http://extendedsubset.com/?p=8 */
+ rv = SSL_OptionSet(nss_fd_, SSL_ENABLE_RENEGOTIATION,
+ SSL_RENEGOTIATE_UNRESTRICTED);
wtc 2010/01/05 19:48:51 We should file a bug to remind us to change this w
+ if (rv != SECSuccess)
+ LOG(INFO) << "SSL_ENABLE_RENEGOTIATION failed.";
+#endif
+
#ifdef SSL_NEXT_PROTO_NEGOTIATED
if (!ssl_config_.next_protos.empty()) {
rv = SSL_SetNextProtoNego(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698