- Increased size of number string cache....

src/heap.cc

 // Copyright 2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1592 matching lines @@
   // Initialize descriptor cache.
   DescriptorLookupCache::Clear();
 
   // Initialize compilation cache.
   CompilationCache::Clear();
 
   return true;
 }
 
 
 static inline int double_get_hash(double d) {

[Kasper Lund, 2009/12/22 11:25:58]

This should really be DoubleGetHash (the same goes for the smi variant).

   DoubleRepresentation rep(d);
-  return ((static_cast<int>(rep.bits) ^ static_cast<int>(rep.bits >> 32)) &
-          (Heap::kNumberStringCacheSize - 1));
+  int value = (static_cast<int>(rep.bits) ^ static_cast<int>(rep.bits >> 32));
+  return (((value >> 16) ^ value))

[Kasper Lund, 2009/12/22 11:25:58]

How about adding another helper function so you can share the ((value >> 16) ^
value)) & (Heap::kNumberStrnigCacheSize - 1) code? (and maybe assert that
Heap::kNumberStringCacheSize is a power of two)

+      & (Heap::kNumberStringCacheSize - 1);
 }
 
 
 static inline int smi_get_hash(Smi* smi) {
-  return (smi->value() & (Heap::kNumberStringCacheSize - 1));
+  return ((smi->value() >> 16) ^ smi->value())
+      & (Heap::kNumberStringCacheSize - 1);
 }
 
 
-
 Object* Heap::GetNumberStringCache(Object* number) {
   int hash;
   if (number->IsSmi()) {
     hash = smi_get_hash(Smi::cast(number));
   } else {
     hash = double_get_hash(number->Number());
   }
   Object* key = number_string_cache()->get(hash * 2);
   if (key == number) {
     return String::cast(number_string_cache()->get(hash * 2 + 1));
@@ skipping 2453 matching lines @@
 void ExternalStringTable::TearDown() {
   new_space_strings_.Free();
   old_space_strings_.Free();
 }
 
 
 List<Object*> ExternalStringTable::new_space_strings_;
 List<Object*> ExternalStringTable::old_space_strings_;
 
 } }  // namespace v8::internal