Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 501169: Add support for 'post_json' url parameter in dromaeo benchmark

Created:
11 years ago by pavel.podivilov
Modified:
10 years, 11 months ago
Reviewers:
Nicolas Sylvain, antonm
Visibility:
Public.

Description

Add support for 'post_json' url parameter in dromaeo benchmark

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/test/data/dromaeo/webrunner.js View 3 chunks +6 lines, -2 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
antonm
Almost LGTM, see minor stylistic nit. If Nicolas is fine w/ the change, he or ...
11 years ago (2009-12-22 17:07:53 UTC) #1
pavel.podivilov
11 years ago (2009-12-22 17:09:10 UTC) #2
pavel.podivilov
http://codereview.chromium.org/501169/diff/1/2 File chrome/test/data/dromaeo/webrunner.js (right): http://codereview.chromium.org/501169/diff/1/2#newcode276 chrome/test/data/dromaeo/webrunner.js:276: automated = true; In fact automated = /^automated/... will ...
11 years ago (2009-12-22 17:19:29 UTC) #3
antonm
Agree, LGTM. (Nicolas, Pavel responded, but didn't send an email).
11 years ago (2009-12-23 14:22:30 UTC) #4
Nicolas Sylvain
LGTM
10 years, 12 months ago (2009-12-26 16:05:11 UTC) #5
pavel.podivilov
10 years, 11 months ago (2010-01-14 17:01:56 UTC) #6

          

Powered by Google App Engine
This is Rietveld 408576698