Adding third_party/ibus-hangul/ to the Chromium OS build.

Adding third_party/ibus-hangul/ to the Chromium OS build.
ibus-hangul provides an input method for Korean.

- third_party/ibus-hangul/libhangul_0.0.10-1.diff.gz
- third_party/ibus-hangul/libhangul_0.0.10.orig.tar.gz

These files are source package of libhangul for Ubuntu Lucid (10.04 LTS) at http://packages.ubuntu.com/en/lucid/libhangul0-data.
Since Karmic's libhangle (0.0.9) is too old to build ibus-hangul trunk, we'll build libhangul packages ourselves.

- third_party/ibus-hangul/make_pkg.sh

This script first builds and installs libhangul debian packages, then builds ibus-hangul.

- third_party/ibus-hangul/ibus-hangul_1.2.0.20090617-2.diff.gz

Copied from the Ubuntu Karmic's ibus-m17n package just like as third_party/clutter/clutter-1.0_1.0.4-0ubuntu1.diff.gz.

- third_party/ibus-hangul/ibus-hangul_remove_python_deps.diff

Patch for third_party/ibus-hangul/debian/rules which removes setup tools written in Python from the ibus-hangul debian package.

[satorux1, 2009-12-22 15:42:52]

http://codereview.chromium.org/501150/diff/1/3
File src/package_repo/package-list-prod.txt (right):

http://codereview.chromium.org/501150/diff/1/3#newcode102
src/package_repo/package-list-prod.txt:102: ibus-hangul
Why don't we have to install libhangul? I thought ibus-hangul depends on
libhangul. Maybe the library is statically linked?

http://codereview.chromium.org/501150/diff/1/9
File src/third_party/ibus-hangul/make_pkg.sh (right):

http://codereview.chromium.org/501150/diff/1/9#newcode37
src/third_party/ibus-hangul/make_pkg.sh:37: tar xvzf
"${TOP_SCRIPT_DIR}/libhangul_0.0.10.orig.tar.gz" -C "${PKG_BUILD_DIR}/"
I understand this is a temporary solution, but having a tar ball in the source
tree is not great in the long run. What about adding a TODO comment saying we
should get rid of this once the new libhangle is included in our deb repository?

[Yusuke Sato, 2009-12-23 13:56:10]

Thanks fixed.

http://codereview.chromium.org/501150/diff/1/3
File src/package_repo/package-list-prod.txt (right):

http://codereview.chromium.org/501150/diff/1/3#newcode102
src/package_repo/package-list-prod.txt:102: ibus-hangul
It's dynamically linked. However we don't have to list libraries ibus-hangul
depends here. The document says:

http://sites.google.com/a/chromium.org/dev/chromium-os/how-tos-and-troublesho...
> package-list-*.txt - High-level list of packages you want
> to install. This does not need to include the transitive
> closure of all dependencies for these packages, nor does
> it need to include version numbers for those packages. 
> Developer-friendly.

http://codereview.chromium.org/501150/diff/1/3#newcode103
src/package_repo/package-list-prod.txt:103: libibus1
I found we can remove L103-104 too! Removed.

http://codereview.chromium.org/501150/diff/1/9
File src/third_party/ibus-hangul/make_pkg.sh (right):

http://codereview.chromium.org/501150/diff/1/9#newcode37
src/third_party/ibus-hangul/make_pkg.sh:37: tar xvzf
"${TOP_SCRIPT_DIR}/libhangul_0.0.10.orig.tar.gz" -C "${PKG_BUILD_DIR}/"
On 2009/12/22 15:42:52, satorux1 wrote:
> I understand this is a temporary solution, but having a tar ball in the source
> tree is not great in the long run. What about adding a TODO comment saying we
> should get rid of this once the new libhangle is included in our deb
repository?

Done.

[satorux1, 2009-12-23 14:24:37]

LGTM

Thank you for the explanation about package-list-prod.txt.