Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 501148: The number of heap slots stored in a scope includes the... (Closed)

Created:
11 years ago by Kasper Lund
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

The number of heap slots stored in a scope includes the fixed contexts slots. Take this into account when using the new, fast context creation path to avoid allocating too many slots (wasteful). Committed: http://code.google.com/p/v8/source/detail?r=3505

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M bleeding_edge/src/contexts.cc View 1 chunk +4 lines, -1 line 0 comments Download
M bleeding_edge/src/execution.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M bleeding_edge/src/ia32/codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M bleeding_edge/src/ia32/macro-assembler-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Kasper Lund
11 years ago (2009-12-21 10:06:40 UTC) #1
Mads Ager (chromium)
11 years ago (2009-12-21 10:18:34 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698