Issue 501143: Remove gclient-specific hacks from trychange into gcl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 501143: Remove gclient-specific hacks from trychange into gcl. (Closed)

Created:
11 years ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Remove gclient-specific hacks from trychange into gcl. Remove upload dependency. This is towards making trychange.py work mostly standalone for the webkit try server. TEST=unit tests and tested both gcl try and git-try.

Patch Set 1 #

Patch Set 2 : 80 cols #

Patch Set 3 : oops, last change was wrong #

Patch Set 4 : Small unit test fix #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -143 lines)			Patch
M	gcl.py	View	1 2	3 chunks	+31 lines, -3 lines	1 comment	Download
M	gclient_utils.py	View		1 chunk	+9 lines, -6 lines	0 comments	Download
M	tests/gclient_utils_test.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/trychange_unittest.py	View		2 chunks	+49 lines, -47 lines	0 comments	Download
M	trychange.py	View	2	6 chunks	+47 lines, -85 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages