Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: base/process_util_mac.mm

Issue 501138: Mac: Create a pid->task_t mapping in the browser process. (Closed)
Patch Set: trunglify Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/process_util_mac.mm
diff --git a/base/process_util_mac.mm b/base/process_util_mac.mm
index dd4dc37bc67c63afbde0f15df1ad332bd41896f8..a7875f3e4e5c9f4f1d50ab9ff7caca261003e149 100644
--- a/base/process_util_mac.mm
+++ b/base/process_util_mac.mm
@@ -193,7 +193,7 @@ bool ProcessMetrics::GetIOCounters(IoCounters* io_counters) const {
}
static bool GetTaskInfo(mach_port_t task, task_basic_info_64* task_info_data) {
- if (!task)
+ if (task == MACH_PORT_NULL)
return false;
mach_msg_type_number_t count = TASK_BASIC_INFO_64_COUNT;
kern_return_t kr = task_info(task,
@@ -250,7 +250,7 @@ bool ProcessMetrics::GetWorkingSetKBytes(WorkingSetKBytes* ws_usage) const {
int ProcessMetrics::GetCPUUsage() {
mach_port_t task = TaskForPid(process_);
- if (!task)
+ if (task == MACH_PORT_NULL)
return 0;
kern_return_t kr;
@@ -317,10 +317,10 @@ int ProcessMetrics::GetCPUUsage() {
}
mach_port_t ProcessMetrics::TaskForPid(ProcessHandle process) const {
- mach_port_t task = 0;
+ mach_port_t task = MACH_PORT_NULL;
if (port_provider_)
task = port_provider_->TaskForPid(process_);
- if (!task && process_ == getpid())
+ if (task == MACH_PORT_NULL && process_ == getpid())
task = mach_task_self();
return task;
}

Powered by Google App Engine
This is Rietveld 408576698