Mac: Create a pid->task_t mapping in the browser process.

chrome/browser/task_manager.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/task_manager.h"
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/compiler_specific.h"
 #include "base/i18n/number_formatting.h"
@@ skipping 11 matching lines @@
 #include "chrome/browser/task_manager_resource_providers.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/pref_service.h"
 #include "chrome/common/url_constants.h"
 #include "grit/app_resources.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_job.h"
 
+#if defined(OS_MACOSX)
+#include "chrome/browser/mach_broker_mac.h"
+#endif
+
 namespace {
 
 // The delay between updates of the information (in ms).
 const int kUpdateTimeMs = 1000;
 
 template <class T>
 int ValueCompare(T value1, T value2) {
   if (value1 < value2)
     return -1;
   if (value1 == value2)
@@ skipping 487 matching lines @@
     new_entry_index = static_cast<int>(iter - resources_.begin());
     resources_.insert(++iter, resource);
   }
 
   // Create the ProcessMetrics for this process if needed (not in map).
   if (metrics_map_.find(process) == metrics_map_.end()) {
     base::ProcessMetrics* pm =
 #if !defined(OS_MACOSX)
         base::ProcessMetrics::CreateProcessMetrics(process);
 #else
-        // TODO(thakis): Write a port provider that knows the task ports of
-        // child processes.
-        base::ProcessMetrics::CreateProcessMetrics(process, NULL);
+        base::ProcessMetrics::CreateProcessMetrics(process,
+                                                   MachBroker::instance());

[jeremy, 2009/12/19 20:49:10]

Can CreateProcessMetrics call MachBroker::instance() itself internally so you
can remove the ifdef here?  Or is there a case where you need to pass in another
broker somewhere else?

[Mark Mentovai, 2009/12/21 19:23:10]

If we can come up with a way to do this without the #ifdef, it'd be cool.

 #endif
 
     metrics_map_[process] = pm;
   }
 
   // Notify the table that the contents have changed for it to redraw.
   FOR_EACH_OBSERVER(TaskManagerModelObserver, observer_list_,
                     OnItemsAdded(new_entry_index, 1));
 }
 
@@ skipping 339 matching lines @@
   // or popup, we can only have one tab, hence we need to process this in a
   // tabbed browser window. Currently, |browser| is pointing to the application,
   // popup window. Therefore, we have to retrieve the last active tab again,
   // since a new window has been used.
   if (browser->type() & Browser::TYPE_APP_POPUP) {
     browser = BrowserList::GetLastActive();
     DCHECK(browser);
   }
   browser->window()->Show();
 }