Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 501136: Merge 34812 - Add the rightclick context menu for Browser actions and Page... (Closed)

Created:
11 years ago by Finnur
Modified:
9 years, 6 months ago
Reviewers:
laforge
CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Merge 34812 - Add the rightclick context menu for Browser actions and Page Actions. BUG=29538 TEST=Rightclick an extension icon and make sure all the options work for both Page and Browser actions (Options should be grayed out when there is no Options page specified in the manifest). TBR=laforge@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -65 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/crx_installer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 2 chunks +2 lines, -39 lines 0 comments Download
A chrome/browser/extensions/extension_action_context_menu_model.h View 1 chunk +40 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_action_context_menu_model.cc View 1 chunk +105 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_disabled_infobar_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extensions_ui.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/views/browser_actions_container.h View 4 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/views/browser_actions_container.cc View 5 chunks +27 lines, -8 lines 0 comments Download
A chrome/browser/views/extensions/extension_action_context_menu.h View 1 chunk +38 lines, -0 lines 0 comments Download
A chrome/browser/views/extensions/extension_action_context_menu.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M chrome/browser/views/location_bar_view.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/views/location_bar_view.cc View 1 chunk +18 lines, -4 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension.h View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension.cc View 2 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Finnur
11 years ago (2009-12-19 04:08:55 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698