Issue 501127: Rearrange build configurations - make it clearer and allow better support for...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 501127: Rearrange build configurations - make it clearer and allow better support for... (Closed)

Created:
11 years ago by gregoryd

Modified:
9 years, 7 months ago

Reviewers:
bradn

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Refactoring build configurations - make it clearer and allow better support for x64 on Windows TEST=none BUG=29467 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35012 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35129

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -70 lines)			Patch
M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	app/app_base.gypi	View	4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
M	base/allocator/allocator.gyp	View	3 4 5 6 7	2 chunks	+2 lines, -2 lines	0 comments	Download
M	breakpad/breakpad.gyp	View	3 4 5 6 7	2 chunks	+2 lines, -2 lines	0 comments	Download
M	breakpad/breakpad_handler.gypi	View	4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
M	breakpad/breakpad_sender.gypi	View	4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
M	build/common.gypi	View	1 2 3 4 5 6 7	10 chunks	+86 lines, -46 lines	0 comments	Download
M	chrome/chrome.gyp	View	3 4 5 6 7	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	4 5 6 7	7 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/installer/installer_util.gypi	View	4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/mini_installer.gyp	View	3 4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/interactive_ui/interactive_ui_tests.gypi	View	4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome_frame/chrome_frame.gyp	View	3 4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
M	ipc/ipc.gypi	View	4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/tcmalloc/tcmalloc.gyp	View	3 4 5 6 7	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

gregoryd

On 2009/12/18 23:36:59, bradn wrote: > LGTM Made some changes. Can you take another look?

11 years ago (2009-12-19 00:07:14 UTC) #3

LGTM