Add two more unit tests for SOCKS5:...

Add two more unit tests for SOCKS5:
  * Check that connecting again after having disconnected works.
  * Check that trying to connect with a very large hostname fails.

Also removes some unused code from socks_client_socket.cc.

BUG=NONE


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35008

[eroman, 2009-12-18 08:19:42]

http://codereview.chromium.org/501112/diff/1/3
File net/socket/socks5_client_socket.cc (right):

http://codereview.chromium.org/501112/diff/1/3#newcode183
net/socket/socks5_client_socket.cc:183: if (0xFF <
host_request_info_.hostname().size())
I moved this check earlier, so we can fail fast before writing bytes to the
transport socket. This simplifies the testing setup required, but also avoids
polluting the transport socket 

(we will need to verify how these sockets are being recycled, since it is
incorrect to recycle the transport socket after a partial handshake).

[wtc, 2009-12-18 21:52:45]

LGTM.

http://codereview.chromium.org/501112/diff/2001/3001
File net/socket/socks5_client_socket_unittest.cc (right):

http://codereview.chromium.org/501112/diff/2001/3001#newcode193
net/socket/socks5_client_socket_unittest.cc:193: // Test that we fail trying to
connect to a hosname larger than 255 bytes.
Nit: larger => longer

http://codereview.chromium.org/501112/diff/2001/3001#newcode203
net/socket/socks5_client_socket_unittest.cc:203: large_host_name, 80));
Just curious -- what's this 80 here?

[eroman, 2009-12-18 22:31:22]

http://codereview.chromium.org/501112/diff/2001/3001
File net/socket/socks5_client_socket_unittest.cc (right):

http://codereview.chromium.org/501112/diff/2001/3001#newcode203
net/socket/socks5_client_socket_unittest.cc:203: large_host_name, 80));
On 2009/12/18 21:52:46, wtc wrote:
> Just curious -- what's this 80 here?

80 is the port number.

<large_host_name>:80 is the target server, which are are asking the SOCKS server
to connect us to.

For this test, the port number doesn't matter.