Get rid of gcl.ReadFile.

scm.py

 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """SCM-specific utility classes."""
 
 import os
 import re
 import subprocess
 import sys
@@ skipping 398 matching lines @@
     else:
       parent_dir = sys.path[0]  # tempdir is not secure.
     bogus_dir = os.path.join(parent_dir, "temp_svn_config")
     if not os.path.exists(bogus_dir):
       os.mkdir(bogus_dir)
     # Grabs the diff data.
     data = SVN.Capture(["diff", "--config-dir", bogus_dir, filename], None)
 
     # We know the diff will be incorrectly formatted. Fix it.
     if SVN.IsMoved(filename):
-      # The file is "new" in the patch sense. Generate a homebrew diff.
-      # We can't use ReadFile() since it's not using binary mode.
-      file_handle = open(filename, 'rb')
-      file_content = file_handle.read()
-      file_handle.close()
+      file_content = gclient_utils.FileRead(filename, 'rb')
       # Prepend '+' to every lines.
       file_content = ['+' + i for i in file_content.splitlines(True)]
       nb_lines = len(file_content)
       # We need to use / since patch on unix will fail otherwise.
       filename = filename.replace('\\', '/')
       data = "Index: %s\n" % filename
       data += ("============================================================="
                "======\n")
       # Note: Should we use /dev/null instead?
       data += "--- %s\n" % filename
@@ skipping 49 matching lines @@
 
     while True:
       key = ReadOneItem('K')
       if not key:
         break
       value = ReadOneItem('V')
       if not value:
         break
       values[key] = value
     return values