Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 501097: Add Immediate command data size validation.... (Closed)

Created:
11 years ago by greggman
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add Immediate command data size validation. Adds checks that Immediate commands all check the sizeo of the data they are going to access is valid. Also adds Vertex Attribute validation for glDrawXXX. In order to accomplish this it must track buffers and their sizes, the settings set with glVertexAttribPointer, program info at glLinkProgram time and which program as active via glUseProgram Given all that info it can validate that is is okay to call glDrawArray or glDrawElements. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35135

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+895 lines, -542 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 3 19 chunks +121 lines, -58 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 26 chunks +561 lines, -87 lines 2 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 2 3 71 chunks +213 lines, -397 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
greggman
11 years ago (2009-12-18 00:41:16 UTC) #1
apatrick
LGTM
11 years ago (2009-12-18 00:50:00 UTC) #2
greggman
Could you re-review this? I got tired of waiting last Friday for the tree to ...
11 years ago (2009-12-22 01:57:53 UTC) #3
apatrick
11 years ago (2009-12-22 02:37:21 UTC) #4
LGTM. I don't think this can break Chrome if you check it it now. I haven't yet
checked in the CL that makes the bots build the command buffer code.

http://codereview.chromium.org/501097/diff/13/4004
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

http://codereview.chromium.org/501097/diff/13/4004#newcode426
gpu/command_buffer/service/gles2_cmd_decoder.cc:426: // Wrapper for glBindBuffer
since we need to track the current targets.
BindBuffer -> DrawArrays

http://codereview.chromium.org/501097/diff/13/4004#newcode507
gpu/command_buffer/service/gles2_cmd_decoder.cc:507: // Infor for each buffer in
the system.
Infor -> Info

Powered by Google App Engine
This is Rietveld 408576698