Issue 501086: Adds build infrastracture for Gtk theme.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 501086: Adds build infrastracture for Gtk theme. (Closed)

Created:
11 years ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Randall Spangler

CC:
chromium-os-reviews_googlegroups.com

Visibility:
Public.

Description

Adds build infrastracture for Gtk theme.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated patch #

Patch Set 3 : Remvoes unneeded import #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+278 lines, -5 lines)			Patch
M	src/package_repo/package-list-prod.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/platform/theme/SConstruct	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
A	src/platform/theme/debian/changelog	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/platform/theme/debian/compat	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	src/platform/theme/debian/control	View		1 chunk	+16 lines, -0 lines	0 comments	Download
A	src/platform/theme/debian/dirs	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	src/platform/theme/debian/postinst	View		1 chunk	+44 lines, -0 lines	0 comments	Download
A	src/platform/theme/debian/postrm	View		1 chunk	+42 lines, -0 lines	0 comments	Download
A	src/platform/theme/debian/preinst	View		1 chunk	+40 lines, -0 lines	0 comments	Download
A	src/platform/theme/debian/prerm	View		1 chunk	+43 lines, -0 lines	0 comments	Download
A	src/platform/theme/debian/rules	View		1 chunk	+62 lines, -0 lines	0 comments	Download
A	src/platform/theme/make_pkg.sh	View		1 chunk	+15 lines, -0 lines	0 comments	Download
D	src/rootfs_static_data/common/etc/gtk-2.0/gtkrc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/scripts/build_platform_packages.sh	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Randall Spangler

11 years ago (2009-12-17 21:31:55 UTC) #3

lgtm with one suggestion

http://codereview.chromium.org/501086/diff/1/3
File src/platform/theme/SConstruct (right):

http://codereview.chromium.org/501086/diff/1/3#newcode5
src/platform/theme/SConstruct:5: import os
Should be able to remove these imports.

Expand Messages | Collapse Messages