Fix some issues found looking at the code....

base/event_recorder.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/event_recorder.h"
 
 #include <mmsystem.h>
 
 #include "base/logging.h"
 #include "base/time.h"
@@ skipping 22 matching lines @@
   return EventRecorder::current()->PlaybackWndProc(nCode, wParam, lParam);
 }
 
 EventRecorder::~EventRecorder() {
   // Try to assert early if the caller deletes the recorder
   // while it is still in use.
   DCHECK(!journal_hook_);
   DCHECK(!is_recording_ && !is_playing_);
 }
 
-bool EventRecorder::StartRecording(std::wstring& filename) {
+bool EventRecorder::StartRecording(const std::wstring& filename) {
   if (journal_hook_ != NULL)
     return false;
   if (is_recording_ || is_playing_)
     return false;
 
   // Open the recording file.
   DCHECK(file_ == NULL);
   if (_wfopen_s(&file_, filename.c_str(), L"wb+") != 0) {
     DLOG(ERROR) << "EventRecorder could not open log file";
     return false;
@@ skipping 29 matching lines @@
 
     DCHECK(file_ != NULL);
     fclose(file_);
     file_ = NULL;
 
     journal_hook_ = NULL;
     is_recording_ = false;
   }
 }
 
-bool EventRecorder::StartPlayback(std::wstring& filename) {
+bool EventRecorder::StartPlayback(const std::wstring& filename) {
   if (journal_hook_ != NULL)
     return false;
   if (is_recording_ || is_playing_)
     return false;
 
   // Open the recording file.
   DCHECK(file_ == NULL);
   if (_wfopen_s(&file_, filename.c_str(), L"rb") != 0) {
     DLOG(ERROR) << "EventRecorder Playback could not open log file";
     return false;
@@ skipping 49 matching lines @@
     ::timeEndPeriod(1);
 
     journal_hook_ = NULL;
     is_playing_ = false;
   }
 }
 
 // Windows callback hook for the recorder.
 LRESULT EventRecorder::RecordWndProc(int nCode, WPARAM wParam, LPARAM lParam) {
   static bool recording_enabled = true;
-  EVENTMSG *msg_ptr = NULL;
+  EVENTMSG* msg_ptr = NULL;
 
   // The API says we have to do this.
   // See http://msdn2.microsoft.com/en-us/library/ms644983(VS.85).aspx
   if (nCode < 0)
     return ::CallNextHookEx(journal_hook_, nCode, wParam, lParam);
 
   // Check for the break key being pressed and stop recording.
   if (::GetKeyState(VK_CANCEL) & 0x8000) {
     StopRecording();
     return ::CallNextHookEx(journal_hook_, nCode, wParam, lParam);
   }
 
   // The Journal Recorder must stop recording events when system modal
   // dialogs are present. (see msdn link above)
-  switch(nCode)
-  {
+  switch(nCode) {
     case HC_SYSMODALON:
-            recording_enabled = false;
+      recording_enabled = false;
       break;
     case HC_SYSMODALOFF:
-            recording_enabled = true;
+      recording_enabled = true;
       break;
   }
 
   if (nCode == HC_ACTION && recording_enabled) {
     // Aha - we have an event to record.
     msg_ptr = reinterpret_cast<EVENTMSG*>(lParam);
     msg_ptr->time = timeGetTime();
     fwrite(msg_ptr, sizeof(EVENTMSG), 1, file_);
     fflush(file_);
   }
 
   return CallNextHookEx(journal_hook_, nCode, wParam, lParam);
 }
 
 // Windows callback for the playback mode.
-LRESULT EventRecorder::PlaybackWndProc(int nCode, WPARAM wParam, LPARAM lParam)
-{
+LRESULT EventRecorder::PlaybackWndProc(int nCode, WPARAM wParam,
+                                       LPARAM lParam) {
   static bool playback_enabled = true;
   int delay = 0;
 
-  switch(nCode)
-  {
+  switch(nCode) {
     // A system modal dialog box is being displayed.  Stop playing back
     // messages.
     case HC_SYSMODALON:
-            playback_enabled = false;
-            break;
+      playback_enabled = false;
+      break;
 
     // A system modal dialog box is destroyed.  We can start playing back
     // messages again.
     case HC_SYSMODALOFF:
-            playback_enabled = true;
-            break;
+      playback_enabled = true;
+      break;
 
     // Prepare to copy the next mouse or keyboard event to playback.
     case HC_SKIP:
-            if (!playback_enabled)
-              break;
+      if (!playback_enabled)
+        break;
 
       // Read the next event from the record.
       if (fread(&playback_msg_, sizeof(EVENTMSG), 1, file_) != 1)
         this->StopPlayback();
-            break;
+      break;
 
     // Copy the mouse or keyboard event to the EVENTMSG structure in lParam.
     case HC_GETNEXT:
-            if (!playback_enabled)
+      if (!playback_enabled)
         break;
 
-      memcpy(reinterpret_cast<void*>(lParam), &playback_msg_, sizeof(playback_msg_));
+      memcpy(reinterpret_cast<void*>(lParam), &playback_msg_,
+             sizeof(playback_msg_));
 
       // The return value is the amount of time (in milliseconds) to wait
       // before playing back the next message in the playback queue.  Each
       // time this is called, we recalculate the delay relative to our current
       // wall clock.
       delay = (playback_msg_.time - playback_first_msg_time_) -
               (timeGetTime() - playback_start_time_);
       if (delay < 0)
         delay = 0;
       return delay;
 
     // An application has called PeekMessage with wRemoveMsg set to PM_NOREMOVE
     // indicating that the message is not removed from the message queue after
     // PeekMessage processing.
     case HC_NOREMOVE:
       break;
   }
 
   return CallNextHookEx(journal_hook_, nCode, wParam, lParam);
 }
 
 }  // namespace base
-