Issue 5008001: Remove suppressions for AtExitManager/Singleton races...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5008001: Remove suppressions for AtExitManager/Singleton races... (Closed)

Created:
10 years, 1 month ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Remove suppressions for AtExitManager/Singleton races These suppressions don't match anything on the bot since r66071 BUG=61585, 61753 TBR=glider TEST=TSan/UI remains green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66119

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -29 lines)			Patch
	M	tools/valgrind/tsan/suppressions.txt	View		1 chunk	+0 lines, -29 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

10 years, 1 month ago (2010-11-15 14:32:36 UTC) #2

LGTM

On Mon, Nov 15, 2010 at 5:17 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Remove suppressions for AtExitManager/Singleton races
> These suppressions don't match anything on the bot since r66071
> BUG=61585,61753
> TBR=glider
> TEST=TSan/UI remains green
>
> Please review this at http://codereview.chromium.org/5008001/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/valgrind/tsan/suppressions.txt
>
>
> Index: tools/valgrind/tsan/suppressions.txt
> ===================================================================
> --- tools/valgrind/tsan/suppressions.txt        (revision 65941)
> +++ tools/valgrind/tsan/suppressions.txt        (working copy)
> @@ -156,35 +156,6 @@
>   fun:exit
>  }
>
> -{
> -  bug_61585a
> -  ThreadSanitizer:UnlockForeign
> -  fun:pthread_mutex_destroy
> -  ...
> -  fun:NSS_Shutdown
> -  ...
> -  fun:*AtExitManager*
> -}
> -
> -{
> -  bug_61585b
> -  ThreadSanitizer:UnlockNonLocked
> -  fun:pthread_mutex_unlock
> -  fun:PR_Unlock
> -  fun:nssSession_ExitMonitor
> -  fun:find_objects
> -  ...
> -  fun:nssTrustDomain_FindCertificatesBySubject
> -  ...
> -}
> -
> -{
> -  bug_61753
> -  ThreadSanitizer:Race
> -  ...
> -  fun:*AtExitManager*
> -}
> -
>  ############################
>  # Data races in tests
>
>
>
>

Expand Messages | Collapse Messages