If building a framework, default the version info.

Make the ObjC linker flag more generic so it only cares if we're building a
bundle (catches frameworks and app and anything else added in the future).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12196

[TVL, 2009-03-20 13:30:34]

The version info is probably optional, if we simply handle loadable bundles by
setting the wrapper extension directly w/in the target GYP markup, they probably
don't want this version info.

(but we probably still need the linker flags)

[TVL, 2009-03-20 13:34:04]

On 2009/03/20 13:30:34, TVL wrote:
> The version info is probably optional, if we simply handle loadable bundles by
> setting the wrapper extension directly w/in the target GYP markup, they
probably
> don't want this version info.

I take that back, the loadable bundle is the same except for the wrapper.type in
the project, so we can't simply use the same flags in the GYP markup, we need
something to tell the generate to build something different.

> 
> (but we probably still need the linker flags)

[Mark Mentovai, 2009-03-20 14:02:14]

http://codereview.chromium.org/50053/diff/1/2
File build/common.gypi (right):

http://codereview.chromium.org/50053/diff/1/2#newcode125
Line 125: 'DYLIB_COMPATIBILITY_VERSION': 1,
DYLIB_COMPATIBILITY_VERSION, DYLIB_CURRENT_VERSION, and FRAMEWORK_VERSION aren't
needed.  In their absence, the toolchain (either Xcode or ld, depending on the
case) will supply sensible defaults.  For shared library bundles (frameworks),
Xcode already defaults to FRAMEWORK_VERSION A, and does not supply dylib
versions so ld will use 0 by default.  This is fine.  For shared library
non-bundles, Xcode supplies a default dylib version of 1.  This is also fine.

We probably want to use -Wl,-ObjC whenever we link any bundled type, right?  I
think you see where I'm going...

[TVL, 2009-03-20 14:31:02]

On 2009/03/20 14:02:14, Mark Mentovai wrote:
> http://codereview.chromium.org/50053/diff/1/2
> File build/common.gypi (right):
> 
> http://codereview.chromium.org/50053/diff/1/2#newcode125
> Line 125: 'DYLIB_COMPATIBILITY_VERSION': 1,
> DYLIB_COMPATIBILITY_VERSION, DYLIB_CURRENT_VERSION, and FRAMEWORK_VERSION
aren't
> needed.  In their absence, the toolchain (either Xcode or ld, depending on the
> case) will supply sensible defaults.  For shared library bundles (frameworks),
> Xcode already defaults to FRAMEWORK_VERSION A, and does not supply dylib
> versions so ld will use 0 by default.  This is fine.  For shared library
> non-bundles, Xcode supplies a default dylib version of 1.  This is also fine.
> 
> We probably want to use -Wl,-ObjC whenever we link any bundled type, right?  I
> think you see where I'm going...

makes sense.

new version up.

[Mark Mentovai, 2009-03-20 15:00:56]

✓+