Issue 5004002: base: Move StringSplitAlongWhitespace to string_split.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5004002: base: Move StringSplitAlongWhitespace to string_split.h (Closed)

Created:
10 years, 1 month ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org, jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

base: Move StringSplitAlongWhitespace to string_split.h BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66181

Patch Set 1 #

Patch Set 2 : unittests #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+113 lines, -111 lines)			Patch
M	base/string_split.h	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	base/string_split.cc	View	1 chunk	+57 lines, -0 lines	0 comments	Download
M	base/string_split_unittest.cc	View	1 chunk	+32 lines, -0 lines	0 comments	Download
M	base/string_util.h	View	2 chunks	+0 lines, -16 lines	0 comments	Download
M	base/string_util.cc	View	1 chunk	+0 lines, -57 lines	0 comments	Download
M	base/string_util_unittest.cc	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model_unittest.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/history/top_sites_database.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/themes/browser_theme_provider.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	net/tools/hresolv/hresolv.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/dom_operations.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nice, LGTM

Expand Messages | Collapse Messages