Fix a bunch of tiny near-bugs and bugs that static analysis identified...

base/stats_table.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/stats_table.h"
 
 #include "base/logging.h"
 #include "base/platform_thread.h"
 #include "base/process_util.h"
 #include "base/scoped_ptr.h"
@@ skipping 484 matching lines @@
 
   return impl_->counter_name(index);
 }
 
 int StatsTable::GetRowValue(int index, int pid) const {
   if (!impl_)
     return 0;
 
   int rv = 0;
   int* row = impl_->row(index);
-  for (int index = 0; index < impl_->max_threads(); index++) {
-    if (pid == 0 || *impl_->thread_pid(index) == pid)
-      rv += row[index];
+  for (int slot_id = 0; slot_id < impl_->max_threads(); slot_id++) {
+    if (pid == 0 || *impl_->thread_pid(slot_id) == pid)
+      rv += row[slot_id];
   }
   return rv;
 }
 
 int StatsTable::GetRowValue(int index) const {
   return GetRowValue(index, 0);
 }
 
 int StatsTable::GetCounterValue(const std::string& name, int pid) {
   if (!impl_)
@@ skipping 33 matching lines @@
   if (!slot && !(slot = table->RegisterThread("")))
       return NULL;
 
   // Find the counter id for the counter.
   std::string str_name(name);
   int counter = table->FindCounter(str_name);
 
   // Now we can find the location in the table.
   return table->GetLocation(counter, slot);
 }