Issue 500120: Added switch to invalidate sync login.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 500120: Added switch to invalidate sync login. (Closed)

Created:
11 years ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
ncarter (slow)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Added switch to invalidate sync login. BUG=none TEST=manual testing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34929

Patch Set 2 : Addressed nick's comments #

Patch Set 3 : synced to head #

Patch Set 4 : synced to head #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
M	chrome/browser/sync/engine/syncapi.cc	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 2 3	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ncarter (slow)

LGTM, one nit. http://codereview.chromium.org/500120/diff/1/2 File chrome/browser/sync/engine/syncapi.cc (right): http://codereview.chromium.org/500120/diff/1/2#newcode20 chrome/browser/sync/engine/syncapi.cc:20: #ifndef NDEBUG A unconditional #include would ...

11 years ago (2009-12-18 00:51:54 UTC) #2

akalin

11 years ago (2009-12-18 00:56:01 UTC) #3

On 2009/12/18 00:51:54, nick wrote:
> LGTM, one nit.
> 
> http://codereview.chromium.org/500120/diff/1/2
> File chrome/browser/sync/engine/syncapi.cc (right):
> 
> http://codereview.chromium.org/500120/diff/1/2#newcode20
> chrome/browser/sync/engine/syncapi.cc:20: #ifndef NDEBUG
> A unconditional #include would be fine in this case, I think.

Done, submitting when the tree opens.