Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: src/virtual-frame.cc

Issue 50012: Change VirtualFrame::AdjustCopies to mark target as invalid. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/virtual-frame-arm.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/virtual-frame.cc
===================================================================
--- src/virtual-frame.cc (revision 1574)
+++ src/virtual-frame.cc (working copy)
@@ -375,18 +375,8 @@
return;
}
- // If the original may be a copy, adjust to preserve the copy-on-write
- // semantics of copied elements.
- if (original.is_copied() &&
- (original.is_register() || original.is_memory())) {
- FrameElement ignored = AdjustCopies(frame_index);
- }
+ InvalidateFrameSlotAt(frame_index);
- // If the original is a register reference, deallocate it.
- if (original.is_register()) {
- Unuse(original.reg());
- }
-
FrameElement new_element;
if (value->is_register()) {
// There are two cases depending no whether the register already
@@ -400,9 +390,9 @@
for (int i = 0; i < elements_.length(); i++) {
FrameElement element = elements_[i];
if (element.is_register() && element.reg().is(value->reg())) {
- // The register backing store is lower in the frame than its
- // copy.
if (i < frame_index) {
+ // The register backing store is lower in the frame than its
+ // copy.
elements_[frame_index] = CopyElementAt(i);
} else {
// There was an early bailout for the case of setting a
« no previous file with comments | « no previous file | src/virtual-frame-arm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698