Issue 500113: EntryKernel: change from assignable refs to puts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 500113: EntryKernel: change from assignable refs to puts. (Closed)

Created:
11 years ago by ncarter (slow)

Modified:
9 years, 7 months ago

Reviewers:
Zachary Kuznia

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

EntryKernel: change from assignable refs to puts. Make EntryKernel have only private data members. When we switch to protobuf based storage, we'll need to use getters and setters. BUG=30041 TEST=unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35879

Patch Set 1 #

Patch Set 2 : Reconciled with latest directory_backing_store #

Patch Set 3 : Resolved conflicts, updated. #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -68 lines)			Patch
M	chrome/browser/sync/syncable/directory_backing_store.cc	View	1 2	1 chunk	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/sync/syncable/syncable.h	View	1 2	5 chunks	+36 lines, -27 lines	0 comments	Download
M	chrome/browser/sync/syncable/syncable.cc	View	1	17 chunks	+34 lines, -34 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages