Revert change 1509 that flush ICs when adding setters on an object or...

src/objects.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2465 matching lines @@
   // Check for lookup interceptor except when bootstrapping.
   if (HasNamedInterceptor() && !Bootstrapper::IsActive()) {
     result->InterceptorResult(this);
     return;
   }
 
   LocalLookupRealNamedProperty(name, result);
 }
 
 
-bool JSObject::HasLocalPropertyWithType(PropertyType type) {
-  if (IsJSGlobalProxy()) {
-    Object* proto = GetPrototype();
-    if (proto->IsNull()) return false;
-    ASSERT(proto->IsJSGlobalObject());
-    return JSObject::cast(proto)->HasLocalPropertyWithType(type);
-  }
-
-  if (HasFastProperties()) {
-    DescriptorArray* descriptors = map()->instance_descriptors();
-    int length = descriptors->number_of_descriptors();
-    for (int i = 0; i < length; i++) {
-      PropertyDetails details(descriptors->GetDetails(i));
-      if (details.type() == type)
-        return true;
-    }
-  } else {
-    Handle<Dictionary> properties = Handle<Dictionary>(property_dictionary());
-    int capacity = properties->Capacity();
-    for (int i = 0; i < capacity; i++) {
-      if (properties->IsKey(properties->KeyAt(i))) {
-        PropertyDetails details = properties->DetailsAt(i);
-        if (details.type() == type)
-          return true;
-      }
-    }
-  }
-
-  return false;
-}
-
-
 void JSObject::Lookup(String* name, LookupResult* result) {
   // Ecma-262 3rd 8.6.2.4
   for (Object* current = this;
        current != Heap::null_value();
        current = JSObject::cast(current)->GetPrototype()) {
     JSObject::cast(current)->LocalLookup(name, result);
     if (result->IsValid() && !result->IsTransitionType()) return;
   }
   result->NotFound();
 }
@@ skipping 107 matching lines @@
     if (dict->IsFailure()) return dict;
 
     // Set the potential new dictionary on the object.
     set_properties(Dictionary::cast(dict));
   }
 
   return structure;
 }
 
 
-Object* JSObject::DefineAccessor(String* name,
-                                 bool is_getter,
-                                 JSFunction* fun,
-                                 PropertyAttributes attributes,
-                                 bool never_used) {
+Object* JSObject::DefineAccessor(String* name, bool is_getter, JSFunction* fun,
+                                 PropertyAttributes attributes) {
   // Check access rights if needed.
   if (IsAccessCheckNeeded() &&
       !Top::MayNamedAccess(this, name, v8::ACCESS_HAS)) {
     Top::ReportFailedAccessCheck(this, v8::ACCESS_HAS);
     return Heap::undefined_value();
   }
 
   if (IsJSGlobalProxy()) {
     Object* proto = GetPrototype();
     if (proto->IsNull()) return this;
     ASSERT(proto->IsJSGlobalObject());
-    return JSObject::cast(proto)->DefineAccessor(name,
-                                                 is_getter,
-                                                 fun,
-                                                 attributes,
-                                                 never_used);
+    return JSObject::cast(proto)->DefineAccessor(name, is_getter,
+                                                 fun, attributes);
   }
 
   Object* array = DefineGetterSetter(name, attributes);
   if (array->IsFailure() || array->IsUndefined()) return array;
   FixedArray::cast(array)->set(is_getter ? 0 : 1, fun);
-
-  // Because setters are nonlocal (they're accessible through the
-  // prototype chain) but our inline caches are local we clear them
-  // when a new setter is introduced.
-  if (!(is_getter || never_used)) Heap::ClearStoreICs();
-
   return this;
 }
 
 
 Object* JSObject::LookupAccessor(String* name, bool is_getter) {
   // Make sure that the top context does not change when doing callbacks or
   // interceptor calls.
   AssertNoContextChange ncc;
 
   // Check access rights if needed.
@@ skipping 4677 matching lines @@
   // No break point.
   if (break_point_objects()->IsUndefined()) return 0;
   // Single beak point.
   if (!break_point_objects()->IsFixedArray()) return 1;
   // Multiple break points.
   return FixedArray::cast(break_point_objects())->length();
 }
 
 
 } }  // namespace v8::internal