Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 50011: Revert change 1509 that flush ICs when adding setters on an object or... (Closed)

Created:
11 years, 9 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Revert change 1509 that flush ICs when adding setters on an object or when setting a __proto__ to an object that holds a setter. This seems to cause a major page load regression, so we need to tune the clearing. Committed: http://code.google.com/p/v8/source/detail?r=1548

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -265 lines) Patch
M src/accessors.cc View 2 chunks +1 line, -9 lines 0 comments Download
M src/heap.h View 3 chunks +0 lines, -13 lines 0 comments Download
M src/heap.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M src/ic.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/messages.js View 3 chunks +4 lines, -4 lines 0 comments Download
M src/objects.h View 2 chunks +1 line, -8 lines 0 comments Download
M src/objects.cc View 3 chunks +4 lines, -48 lines 0 comments Download
M src/regexp-delay.js View 3 chunks +14 lines, -17 lines 0 comments Download
M src/runtime.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M src/v8-counters.h View 1 chunk +1 line, -2 lines 0 comments Download
D test/mjsunit/regress/regress-1344252.js View 1 chunk +0 lines, -76 lines 0 comments Download
D test/mjsunit/regress/regress-92.js View 1 chunk +0 lines, -67 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
11 years, 9 months ago (2009-03-19 15:03:31 UTC) #1
Christian Plesner Hansen
11 years, 9 months ago (2009-03-20 20:08:59 UTC) #2
Lgtm.

We knew this might be the case and there is a number of ways this change can be
improved.  I'd like to do some experiments, any way for me to run whatever
showed the regression on a local machine, or something that would show the same
regression?

Powered by Google App Engine
This is Rietveld 408576698