Issue 5001002: A second attempt at forcing 8-byte alignment of the time stamp....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5001002: A second attempt at forcing 8-byte alignment of the time stamp.... (Closed)

Created:
10 years, 1 month ago by dmichael(do not use this one)

Modified:
9 years, 7 months ago

Reviewers:
sehr (please use chromium), darin (slow to review), sehr

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

A second attempt at forcing 8-byte alignment of the time stamp. I used padding this time. pragma pack didn't work on Mac x86-32. It seems to be an issue that only some (very recent?) versions of GCC support it. I could do it with macros, but it would be ugly. See the updated bug for more details. Try was clean: http://build.chromium.org/p/tryserver.chromium/waterfall?committer=dmichael@google.com BUG=62983 TEST=I use a compile assert to ensure the size is consistent. Assuming this goes well, I'll do a future CL to scan other structs and tweak them to get consistent alignment if I find any other problems. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66446

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
	M	ppapi/c/pp_input_event.h	View	1 2 3	2 chunks	+5 lines, -7 lines	0 comments	Download
	M	ppapi/c/ppp_instance.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dmichael(do not use this one)

Renamed _pad_do_not_use to padding.

10 years, 1 month ago (2010-11-16 23:31:03 UTC) #1

sehr (please use chromium)

10 years, 1 month ago (2010-11-16 23:40:34 UTC) #3

LGTM.

On Tue, Nov 16, 2010 at 3:37 PM, <darin@chromium.org> wrote:

> LGTM
>
>
> http://codereview.chromium.org/5001002/
>

Expand Messages | Collapse Messages