Fix link failure on LTCG builds....

Fix link failure on LTCG builds.

Reenable SVGAllInOne.cpp. This required some fixups.

Namely, there was conflicts in constants between HTMLNames and SVGNames, and conflicts between static functions.

BUG=30494
TEST=compiles in LTCG builds on Windows

[M-A Ruel, 2009-12-17 17:33:02]

Brad, can you look the gyp is fine.
Stephen, can you make sure the changes looks fine?

[bradn, 2009-12-17 18:04:45]

LGTM,
This actually pushes things down where it links?

[M-A Ruel, 2009-12-17 18:07:45]

On 2009/12/17 18:04:45, bradn wrote:
> LGTM,
> This actually pushes things down where it links?

Yes, but it's been linking for ... a while now; ~30 minutes. Will commit only if
it actually links.

[Stephen White, 2009-12-17 18:09:15]

http://codereview.chromium.org/500099/diff/1009/14
File svg/SVGAllInOne.cpp (right):

http://codereview.chromium.org/500099/diff/1009/14#newcode42
svg/SVGAllInOne.cpp:42: #include "SVGComponentTransferFunctionElement.cpp"
Is this file supposed to have svg/*.cpp?  If so, it's missing the files for
filters, e.g., SVGFECompositeElement.cpp, SVGFEGaussianBlurElement.cpp, etc. 
And perhaps some non-filters files, but I didn't check.

Filters are not enabled on 249 branch, but I think it should be okay to add them
anyway (the #if ENABLE's in each file should take care of it).

[M-A Ruel, 2009-12-17 18:14:44]

On 2009/12/17 18:09:15, Stephen White wrote:
> http://codereview.chromium.org/500099/diff/1009/14
> File svg/SVGAllInOne.cpp (right):
> 
> http://codereview.chromium.org/500099/diff/1009/14#newcode42
> svg/SVGAllInOne.cpp:42: #include "SVGComponentTransferFunctionElement.cpp"
> Is this file supposed to have svg/*.cpp?  If so, it's missing the files for
> filters, e.g., SVGFECompositeElement.cpp, SVGFEGaussianBlurElement.cpp, etc. 
> And perhaps some non-filters files, but I didn't check.
> 
> Filters are not enabled on 249 branch, but I think it should be okay to add
them
> anyway (the #if ENABLE's in each file should take care of it).

No, it has svg/[^/]*\.cpp$ so it doesn't have animation/ nor graphics/.

[Stephen White, 2009-12-17 18:17:30]

On 2009/12/17 18:14:44, Marc-Antoine Ruel wrote:
> On 2009/12/17 18:09:15, Stephen White wrote:
> > http://codereview.chromium.org/500099/diff/1009/14
> > File svg/SVGAllInOne.cpp (right):
> > 
> > http://codereview.chromium.org/500099/diff/1009/14#newcode42
> > svg/SVGAllInOne.cpp:42: #include "SVGComponentTransferFunctionElement.cpp"
> > Is this file supposed to have svg/*.cpp?  If so, it's missing the files for
> > filters, e.g., SVGFECompositeElement.cpp, SVGFEGaussianBlurElement.cpp, etc.

> > And perhaps some non-filters files, but I didn't check.
> > 
> > Filters are not enabled on 249 branch, but I think it should be okay to add
> them
> > anyway (the #if ENABLE's in each file should take care of it).
> 
> No, it has svg/[^/]*\.cpp$ so it doesn't have animation/ nor graphics/.

Fair enough, but it seems to be missing some stuff in svg/ root too (see above
for examples).

[Stephen White, 2009-12-17 18:24:53]

On 2009/12/17 18:17:30, Stephen White wrote:

> Fair enough, but it seems to be missing some stuff in svg/ root too (see above
> for examples).

Never mind -- I'm an idiot; I was only looking at the diffs, not the whole file.
 Sorry for the noise.

LGTM