Issue 500075: Fix a regression introduced by r33225....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 500075: Fix a regression introduced by r33225.... (Closed)

Created:
11 years ago by huanr

Modified:
9 years ago

Reviewers:
Jói

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix a regression introduced by r33225. On windows, if CreateDirectory is called with an path on an inaccessible drive, it will enter an infinite loop. BUG=30415 TEST=base_unittests.exe --gtest_filter=FileUtilTest.CreateDirectoryTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34871

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	base/file_util_unittest.cc	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
	M	base/file_util_win.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jói

11 years ago (2009-12-17 14:14:04 UTC) #2

LGTM
(once try bots are happy)

Sorry about the bug, and thanks for the fix + regression test.

Expand Messages | Collapse Messages