Factor tab context menu into a shared model and fix mac and win to use it. Im...

chrome/browser/app_menu_model_unittest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved. Use of this
 // source code is governed by a BSD-style license that can be found in the
 // LICENSE file.
 
 #include "chrome/browser/app_menu_model.h"
 
 #include "base/logging.h"
 #include "chrome/test/browser_with_test_window_test.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 13 matching lines @@
       menus::Accelerator* accelerator) { return false; }
   virtual void ExecuteCommand(int command_id) { ++execute_count_; }
 
   int execute_count_;
   mutable int enable_count_;
 };
 
 class AppMenuModelTest : public BrowserWithTestWindowTest {
 };
 
+// Recursively checks the enabled state and executes a command on every item
+// that's not a separator or a submenu parent item. The returned count should
+// match the number of times the delegate is called to ensure every item works.
+static void CountEnabledExecutable(menus::MenuModel* model, int* count) {
+  for (int i = 0; i < model->GetItemCount(); ++i) {
+    menus::MenuModel::ItemType type = model->GetTypeAt(i);
+    switch (type) {
+      case menus::MenuModel::TYPE_SEPARATOR:
+        continue;
+      case menus::MenuModel::TYPE_SUBMENU:
+        CountEnabledExecutable(model->GetSubmenuModelAt(i), count);
+        break;
+      default:
+        model->IsEnabledAt(i);  // Check if it's enabled (ignore answer).
+        model->ActivatedAt(i);  // Execute it.
+        (*count)++;  // Increment the count of executable items seen.
+        break;
+    }
+  }
+}
+
 TEST_F(AppMenuModelTest, Basics) {
   Delegate delegate;
   AppMenuModel model(&delegate, browser());
 
   // Verify it has items. The number varies by platform, so we don't check
   // the exact number.
   EXPECT_GT(model.GetItemCount(), 5);
 
-  // Execute a couple of the items and make sure it gets back to our delegate.
-  model.ActivatedAt(0);
-  EXPECT_TRUE(model.IsEnabledAt(0));
-  model.ActivatedAt(3);
-  EXPECT_TRUE(model.IsEnabledAt(4));
-  EXPECT_EQ(delegate.execute_count_, 2);
-  EXPECT_EQ(delegate.enable_count_, 2);
-
-  delegate.execute_count_ = 0;
-  delegate.enable_count_ = 0;
+  int item_count = 0;
+  CountEnabledExecutable(&model, &item_count);
+  EXPECT_GT(item_count, 0);
+  EXPECT_EQ(item_count, delegate.execute_count_);
+  EXPECT_EQ(item_count, delegate.enable_count_);
 }