Factor tab context menu into a shared model and fix mac and win to use it. Im...

Factor tab context menu into a shared model and fix mac and win to use it. Improve a couple of model unit tests. Remove unused members in the models.
BUG=28977
TEST=context menus on tabs should work and enable/disable properly

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34718

[pink (ping after 24hrs), 2009-12-15 22:36:52]

Trybots are being flaky, I'm still working through them, though everything
compiles.

[viettrungluu, 2009-12-15 23:18:45]

LGTM on the code itself. Could we come up with a common framework for testing
the various menus?

Otherwise, since it compiles, ship it! :)

http://codereview.chromium.org/500030/diff/4001/4007
File chrome/browser/tab_menu_model_unittest.cc (right):

http://codereview.chromium.org/500030/diff/4001/4007#newcode9
chrome/browser/tab_menu_model_unittest.cc:9: #include
"testing/gtest/include/gtest/gtest.h"
g < p, and we usually order in the simplest way, I think.

http://codereview.chromium.org/500030/diff/4001/4007#newcode13
chrome/browser/tab_menu_model_unittest.cc:13: class Delegate : public
menus::SimpleMenuModel::Delegate {
I've seen this before. Perhaps we should have a file with common code for
testing the menus?

http://codereview.chromium.org/500030/diff/4001/4007#newcode37
chrome/browser/tab_menu_model_unittest.cc:37: static void
CountEnabledExecutable(menus::MenuModel* model, int* count) {
This too.

[pink (ping after 24hrs), 2009-12-16 14:52:49]

http://codereview.chromium.org/500030/diff/4001/4007
File chrome/browser/tab_menu_model_unittest.cc (right):

http://codereview.chromium.org/500030/diff/4001/4007#newcode9
chrome/browser/tab_menu_model_unittest.cc:9: #include
"testing/gtest/include/gtest/gtest.h"
On 2009/12/15 23:18:45, viettrungluu wrote:
> g < p, and we usually order in the simplest way, I think.

Done.

http://codereview.chromium.org/500030/diff/4001/4007#newcode13
chrome/browser/tab_menu_model_unittest.cc:13: class Delegate : public
menus::SimpleMenuModel::Delegate {
On 2009/12/15 23:18:45, viettrungluu wrote:
> I've seen this before. Perhaps we should have a file with common code for
> testing the menus?

I'll refactor this in a new cl, i don't want to clog up this CL since the
trybots are giving me such fits. I'll make a new parent class that houses this
and the method below these tests can inherit from.

http://codereview.chromium.org/500030/diff/4001/4007#newcode37
chrome/browser/tab_menu_model_unittest.cc:37: static void
CountEnabledExecutable(menus::MenuModel* model, int* count) {
On 2009/12/15 23:18:45, viettrungluu wrote:
> This too.

same.

[viettrungluu, 2009-12-16 15:01:38]

Fair enough. LGTM.