Issue 5000002: [Sync] Fix modification-while-iterating bug in extensions integration tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5000002: [Sync] Fix modification-while-iterating bug in extensions integration tests (Closed)

Created:
10 years, 1 month ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
Raghu Simha

CC:
chromium-reviews, ncarter (slow), idana, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Sync] Fix modification-while-iterating bug in extensions integration tests BUG=None TEST=Windows integration tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66199

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome/test/live_sync/live_extensions_sync_test_base.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

akalin

+rsimha for review Can you try this on your local windows checkout to see if ...

10 years, 1 month ago (2010-11-15 23:43:31 UTC) #1

Raghu Simha

10 years, 1 month ago (2010-11-15 23:55:29 UTC) #2

On 2010/11/15 23:43:31, akalin wrote:
> +rsimha for review
> 
> Can you try this on your local windows checkout to see if this fixes the
> problem, too?

LGTM. Verified on my windows machine. Feel free to commit. Thanks for fixing
this.

Expand Messages | Collapse Messages