Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 4998004: Add port flag to remote_rsync_from (Closed)

Created:
10 years, 1 month ago by Paul Stewart
Modified:
9 years, 7 months ago
Reviewers:
kmixter1
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Add port flag to remote_rsync_from Ass ${FLAGS_ssh_port} to ssh arguments for rsync BUG=chromium-os:9187 TEST=Run rsync-related script with port argument Change-Id: Iefabef230cfff03dcd66ac0c24798bb4b13ce40d Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=b94e402

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M remote_access.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Stewart
10 years, 1 month ago (2010-11-15 21:36:03 UTC) #1
kmixter1
10 years, 1 month ago (2010-11-15 21:38:04 UTC) #2
LGTM

On Mon, Nov 15, 2010 at 1:36 PM, <pstew@chromium.org> wrote:

> Reviewers: kmixter1,
>
> Description:
> Add port flag to remote_rsync_from
>
> Ass ${FLAGS_ssh_port} to ssh arguments for rsync
>
> BUG=none
> TEST=Run rsync-related script with port argument
>
> Change-Id: Iefabef230cfff03dcd66ac0c24798bb4b13ce40d
>
> Please review this at http://codereview.chromium.org/4998004/
>
> SVN Base: http://git.chromium.org/git/crosutils.git@master
>
> Affected files:
>  M remote_access.sh
>
>
> Index: remote_access.sh
> diff --git a/remote_access.sh b/remote_access.sh
> index
>
092555a5bd61f9e8ea3bb0714eda7ac816ceb469..f3d490ab973e03d8011b142ded42341ea0a43297
> 100644
> --- a/remote_access.sh
> +++ b/remote_access.sh
> @@ -23,7 +23,7 @@ function remote_cp_to() {
>  # Copies a list of remote files specified in file $1 to local location
>  # $2.  Directory paths in $1 are collapsed into $2.
>  function remote_rsync_from() {
> -  rsync -e "ssh -o StrictHostKeyChecking=no -o \
> +  rsync -e "ssh -p ${FLAGS_ssh_port} -o StrictHostKeyChecking=no -o \
>             UserKnownHostsFile=$TMP_KNOWN_HOSTS" --no-R \
>     --files-from=$1 root@${FLAGS_remote}:/ $2
>  }
>
>
>

Powered by Google App Engine
This is Rietveld 408576698