Issue 4998003: Not running the following Chromeframe tests on IE9. This will enable the buil...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4998003: Not running the following Chromeframe tests on IE9. This will enable the buil... (Closed)

Created:
10 years, 1 month ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
amit

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Not running the following Chromeframe tests on IE9. This will enable the builder to now run the tests to completion and hopefully turn green. 1. CF_DownloadFileFromPost. This test expects to see a File save dialog. On IE9 the prompt to save the file is displayed as a link on the frame window. 2. WidgetModeIE_CFInstancePost, WidgetModeIE_CFInstanceRPC, WidgetModeIE_CFInstanceRPCInterna These tests fail on IE9. Needs more investigation. TBR=amit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66158

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -5 lines)			Patch
	M	chrome_frame/test/navigation_test.cc	View		1 chunk	+9 lines, -4 lines	1 comment	Download
	M	chrome_frame/test/test_with_web_server.cc	View	1	4 chunks	+14 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

amit

10 years, 1 month ago (2010-11-15 21:25:43 UTC) #2

lgtm

http://codereview.chromium.org/4998003/diff/5001/chrome_frame/test/navigation...
File chrome_frame/test/navigation_test.cc (right):

http://codereview.chromium.org/4998003/diff/5001/chrome_frame/test/navigation...
chrome_frame/test/navigation_test.cc:755: } else if (GetInstalledIEVersion() ==
IE_9) {
nit: wouldn't be better to call GetInstalledIEVersion() just once?

Expand Messages | Collapse Messages