Issue 4997002: IE CEEE: Explicitly assign window properties/methods into the script host glo...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4997002: IE CEEE: Explicitly assign window properties/methods into the script host glo... (Closed)

Created:
10 years, 1 month ago by Eric Dingle

Modified:
9 years, 7 months ago

Reviewers:
Sigurður Ásgeirsson

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

IE CEEE: Explicitly assign window properties/methods into the script host global namespace instead of automatically. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66144

Patch Set 1 #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -23 lines)			Patch
M	ceee/ie/plugin/scripting/ceee_bootstrap.js	View	1 chunk	+54 lines, -1 line	0 comments	Download
M	ceee/ie/plugin/scripting/content_script_manager.cc	View	2 chunks	+9 lines, -3 lines	2 comments	Download
M	ceee/ie/plugin/scripting/content_script_manager_unittest.cc	View	1 chunk	+20 lines, -19 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sigurður Ásgeirsson

lgtm http://codereview.chromium.org/4997002/diff/1/ceee/ie/plugin/scripting/content_script_manager.cc File ceee/ie/plugin/scripting/content_script_manager.cc (right): http://codereview.chromium.org/4997002/diff/1/ceee/ie/plugin/scripting/content_script_manager.cc#newcode160 ceee/ie/plugin/scripting/content_script_manager.cc:160: if (FAILED(hr)) thanks... Can you see whether the ...

10 years, 1 month ago (2010-11-15 16:33:30 UTC) #2

Eric Dingle

10 years, 1 month ago (2010-11-15 16:37:51 UTC) #3

Thanks! Submitting.

http://codereview.chromium.org/4997002/diff/1/ceee/ie/plugin/scripting/conten...
File ceee/ie/plugin/scripting/content_script_manager.cc (right):

http://codereview.chromium.org/4997002/diff/1/ceee/ie/plugin/scripting/conten...
ceee/ie/plugin/scripting/content_script_manager.cc:160: if (FAILED(hr))
This method is private and only called internally. The caller (also a private
method) does log errors on failure :)

On 2010/11/15 16:33:30, Ruðrugis wrote:
> thanks...
> Can you see whether the caller logs errors, and if not, add logging to the
error
> cases here?

Expand Messages | Collapse Messages