Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Side by Side Diff: chrome/browser/tab_contents/provisional_load_details.h

Issue 4997001: C++ readability change for jochen (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/browser/extensions
Patch Set: more long long to int64 Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_TAB_CONTENTS_PROVISIONAL_LOAD_DETAILS_H_ 5 #ifndef CHROME_BROWSER_TAB_CONTENTS_PROVISIONAL_LOAD_DETAILS_H_
6 #define CHROME_BROWSER_TAB_CONTENTS_PROVISIONAL_LOAD_DETAILS_H_ 6 #define CHROME_BROWSER_TAB_CONTENTS_PROVISIONAL_LOAD_DETAILS_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 10 matching lines...) Expand all
21 // TODO(brettw) this mostly duplicates 21 // TODO(brettw) this mostly duplicates
22 // NavigationController::LoadCommittedDetails, it would be nice to unify these 22 // NavigationController::LoadCommittedDetails, it would be nice to unify these
23 // somehow. 23 // somehow.
24 class ProvisionalLoadDetails { 24 class ProvisionalLoadDetails {
25 public: 25 public:
26 ProvisionalLoadDetails(bool main_frame, 26 ProvisionalLoadDetails(bool main_frame,
27 bool in_page_navigation, 27 bool in_page_navigation,
28 const GURL& url, 28 const GURL& url,
29 const std::string& security_info, 29 const std::string& security_info,
30 bool is_filtered, 30 bool is_filtered,
31 long long frame_id); 31 int64 frame_id);
32 virtual ~ProvisionalLoadDetails() { } 32 virtual ~ProvisionalLoadDetails() { }
33 33
34 void set_error_code(int error_code) { error_code_ = error_code; } 34 void set_error_code(int error_code) { error_code_ = error_code; }
35 int error_code() const { return error_code_; } 35 int error_code() const { return error_code_; }
36 36
37 void set_transition_type(PageTransition::Type transition_type) { 37 void set_transition_type(PageTransition::Type transition_type) {
38 transition_type_ = transition_type; 38 transition_type_ = transition_type;
39 } 39 }
40 PageTransition::Type transition_type() const { 40 PageTransition::Type transition_type() const {
41 return transition_type_; 41 return transition_type_;
42 } 42 }
43 43
44 const GURL& url() const { return url_; } 44 const GURL& url() const { return url_; }
45 45
46 bool main_frame() const { return is_main_frame_; } 46 bool main_frame() const { return is_main_frame_; }
47 47
48 bool in_page_navigation() const { return is_in_page_navigation_; } 48 bool in_page_navigation() const { return is_in_page_navigation_; }
49 49
50 int ssl_cert_id() const { return ssl_cert_id_; } 50 int ssl_cert_id() const { return ssl_cert_id_; }
51 51
52 int ssl_cert_status() const { return ssl_cert_status_; } 52 int ssl_cert_status() const { return ssl_cert_status_; }
53 53
54 int ssl_security_bits() const { return ssl_security_bits_; } 54 int ssl_security_bits() const { return ssl_security_bits_; }
55 55
56 int ssl_connection_status() const { return ssl_connection_status_; } 56 int ssl_connection_status() const { return ssl_connection_status_; }
57 57
58 bool is_content_filtered() const { return is_content_filtered_; } 58 bool is_content_filtered() const { return is_content_filtered_; }
59 59
60 long long frame_id() const { return frame_id_; } 60 int64 frame_id() const { return frame_id_; }
61 61
62 private: 62 private:
63 int error_code_; 63 int error_code_;
64 PageTransition::Type transition_type_; 64 PageTransition::Type transition_type_;
65 GURL url_; 65 GURL url_;
66 bool is_main_frame_; 66 bool is_main_frame_;
67 bool is_in_page_navigation_; 67 bool is_in_page_navigation_;
68 int ssl_cert_id_; 68 int ssl_cert_id_;
69 int ssl_cert_status_; 69 int ssl_cert_status_;
70 int ssl_security_bits_; 70 int ssl_security_bits_;
71 int ssl_connection_status_; 71 int ssl_connection_status_;
72 bool is_content_filtered_; 72 bool is_content_filtered_;
73 long long frame_id_; 73 int64 frame_id_;
74 74
75 DISALLOW_COPY_AND_ASSIGN(ProvisionalLoadDetails); 75 DISALLOW_COPY_AND_ASSIGN(ProvisionalLoadDetails);
76 }; 76 };
77 77
78 #endif // CHROME_BROWSER_TAB_CONTENTS_PROVISIONAL_LOAD_DETAILS_H_ 78 #endif // CHROME_BROWSER_TAB_CONTENTS_PROVISIONAL_LOAD_DETAILS_H_
OLDNEW
« no previous file with comments | « chrome/browser/renderer_host/render_view_host_delegate.h ('k') | chrome/browser/tab_contents/provisional_load_details.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698