Issue 4991006: Run Pepper unit tests in Native Client....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4991006: Run Pepper unit tests in Native Client.... (Closed)

Created:
10 years, 1 month ago by garianov

Modified:
9 years, 7 months ago

Reviewers:
David Springer, darin (slow to review)

CC:
chromium-reviews

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Run Pepper unit tests in Native Client. This is a copy of approved CL http://codereview.chromium.org/3993001/ The purpose is to patch moved ppapi repository. BUG = http://code.google.com/p/nativeclient/issues/detail?id=902 TEST = load scons-out/.../ppapi_tests.html in a Pepper2-enabled Chrome browser.

Patch Set 1 #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -15 lines)			Patch
M	ppapi/c/dev/ppb_char_set_dev.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/cpp/var.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ppapi/cpp/var.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	ppapi/tests/test_case.html	View	1 chunk	+34 lines, -11 lines	1 comment	Download
M	ppapi/tests/testing_instance.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ppapi/tests/testing_instance.cc	View	2 chunks	+15 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

10 years, 1 month ago (2010-11-16 00:23:20 UTC) #2

LGTM

http://codereview.chromium.org/4991006/diff/1/ppapi/tests/test_case.html
File ppapi/tests/test_case.html (right):

http://codereview.chromium.org/4991006/diff/1/ppapi/tests/test_case.html#newc...
ppapi/tests/test_case.html:51: function ExtractSearchParameter( name ) {
style nit: no spaces around the parameter name

Expand Messages | Collapse Messages