Issue 4991003: Revert 66125 -- Broke Windows build - Move FilterType into MediaFilterCollect...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4991003: Revert 66125 -- Broke Windows build - Move FilterType into MediaFilterCollect... (Closed)

Created:
10 years, 1 month ago by levin

Modified:
9 years, 7 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
chromium-reviews, vrk (LEFT CHROMIUM), fbarchard, ddorwin+watch_chromium.org, Alpha Left Google, brettw-cc_chromium.org, annacc, pam+watch_chromium.org, awong, Paweł Hajdan Jr., darin-cc_chromium.org, scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 66125 -- Broke Windows build - Move FilterType into MediaFilterCollection MediaFilterCollection is the only code that uses FilterType now so I'm moving the enum into that class and removing all references from the MediaFilter & derived classes. BUG=61823 TEST=No new functionality. Existing tests pass. Review URL: http://codereview.chromium.org/4653005 TBR=acolwell@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66139

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+126 lines, -154 lines)			Patch
M	chrome/renderer/render_view.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	media/base/filters.h	View	8 chunks	+34 lines, -0 lines	0 comments	Download
M	media/base/filters.cc	View	4 chunks	+24 lines, -0 lines	0 comments	Download
M	media/base/media_filter_collection.h	View	2 chunks	+8 lines, -35 lines	0 comments	Download
M	media/base/media_filter_collection.cc	View	2 chunks	+5 lines, -66 lines	0 comments	Download
M	media/base/media_filter_collection_unittest.cc	View	3 chunks	+18 lines, -18 lines	0 comments	Download
M	media/base/mock_filters.h	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	media/base/pipeline_impl.cc	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	media/filters/decoder_base_unittest.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	media/tools/player_x11/player_x11.cc	View	1 chunk	+8 lines, -10 lines	0 comments	Download
M	webkit/glue/webmediaplayer_impl.cc	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	webkit/support/webkit_support.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

acolwell GONE FROM CHROMIUM

10 years, 1 month ago (2010-11-15 20:24:33 UTC) #3

Yep. I'm aware. Sorry again. Updated patch is on the trybots now.
On 2010/11/15 20:20:20, levin wrote:
> I believe you're aware of this but publishing to be sure.

Expand Messages | Collapse Messages