Firing event to broker without worker thread.

ceee/ie/plugin/bho/events_funnel.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Common base class for funnels of Chrome Extension events that originate
 // from the BHO and are sent to the Broker.
 
 #include "ceee/ie/plugin/bho/events_funnel.h"
 
 #include "base/json/json_writer.h"
 #include "base/logging.h"
 #include "base/values.h"
 #include "ceee/ie/common/ceee_module_util.h"
 
 
 EventsFunnel::EventsFunnel(bool keep_broker_alive)

[Sigurður Ásgeirsson, 2010/11/16 18:23:04]

IMHO it would it simplify everything to keep an RpcClient per EventsFunnel. We'd
maintain one Rpc connection per tab, that way, which is slightly higher cost,
but we then also have an Rpc server context per tab.
The worker thread was originally single-instanced due to the cost, but that
argument no longer applies, IMHO. 

[Vitaly Buka corp, 2010/11/18 23:14:21]

Done.

     : keep_broker_alive_(keep_broker_alive) {
   if (keep_broker_alive_)
-    ceee_module_util::AddRefModuleWorkerThread();
+    ceee_module_util::AddRefBroker();
 }
 
 EventsFunnel::~EventsFunnel() {
   if (keep_broker_alive_)
-    ceee_module_util::ReleaseModuleWorkerThread();
+    ceee_module_util::ReleaseBroker();
 }
 
 HRESULT EventsFunnel::SendEvent(const char* event_name,
                                 const Value& event_args) {
   // Event arguments for FireEventToBroker always need to be stored in a list.
   std::string event_args_str;
   if (event_args.IsType(Value::TYPE_LIST)) {
     base::JSONWriter::Write(&event_args, false, &event_args_str);
   } else {
     ListValue list;
     list.Append(event_args.DeepCopy());
     base::JSONWriter::Write(&list, false, &event_args_str);
   }
 
   EventsFunnel thread_locker(!keep_broker_alive_);
   ceee_module_util::FireEventToBroker(event_name, event_args_str);
   return S_OK;
 }