|
Attempt to reland http://codereview.chromium.org/4928002/
For some reason the Win bot failed to compile the sandbox unit test.
Trybots and my machines don't have these build problems, so I'm going to try again, unchanged.
Original description:
Changing the installer switches from wchar_t[] to char[].
Because of this I'm also refactoring some code that before
was using wstring to build command lines by hand instead of
using the CommandLine class. Now we use CommandLine.
To get this to work correctly, I also needed to fix CommandLine::AppendArguments so I added a little test for it.
TEST=There should be no changes in functionality. Run all installer tests.
BUG= 61609
TBR=robertshield
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66096
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+201 lines, -180 lines) |
Patch |
|
M |
base/command_line.cc
|
View
|
|
2 chunks |
+16 lines, -3 lines |
0 comments
|
Download
|
|
M |
base/command_line_unittest.cc
|
View
|
|
2 chunks |
+26 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/browser_main_win.cc
|
View
|
|
1 chunk |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/installer/setup/install.cc
|
View
|
|
3 chunks |
+19 lines, -28 lines |
0 comments
|
Download
|
|
M |
chrome/installer/setup/setup_main.cc
|
View
|
|
4 chunks |
+5 lines, -8 lines |
0 comments
|
Download
|
|
M |
chrome/installer/setup/uninstall.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/installer/setup/uninstall.cc
|
View
|
|
2 chunks |
+8 lines, -12 lines |
0 comments
|
Download
|
|
M |
chrome/installer/util/google_chrome_distribution.cc
|
View
|
|
3 chunks |
+7 lines, -9 lines |
0 comments
|
Download
|
|
M |
chrome/installer/util/install_util.h
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/installer/util/install_util.cc
|
View
|
|
2 chunks |
+18 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/installer/util/master_preferences.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/installer/util/master_preferences_unittest.cc
|
View
|
|
2 chunks |
+26 lines, -33 lines |
0 comments
|
Download
|
|
M |
chrome/installer/util/shell_util.cc
|
View
|
|
2 chunks |
+12 lines, -15 lines |
0 comments
|
Download
|
|
M |
chrome/installer/util/util_constants.h
|
View
|
|
1 chunk |
+26 lines, -26 lines |
0 comments
|
Download
|
|
M |
chrome/installer/util/util_constants.cc
|
View
|
|
4 chunks |
+27 lines, -27 lines |
0 comments
|
Download
|
|