Special-case preflight clean to allow for missing directories.

Special-case preflight clean to allow for missing directories.
    
If there's no directory, I guess things are really, really clean.
    
BUG=chromium-os:9197
TEST=Ran cros_mark_as_stable.py clean with missing overlay directories.

Change-Id: I3f4811fe01bca56e850f823a973476884292e278

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f7502a6

[scottz, 2010-11-16 01:49:21]

LGTM

[sosa, 2010-11-16 01:51:13]

This isn't the right fix.  

Clobber can leave some bad state behind that rinse will take care of.  If rinse
can't be run without the src tree than that should be fixed.

[sosa, 2010-11-16 01:55:15]

Sorry to had to type that fast to potentially keep you from committing.

The whole purpose of doing pre flight rinse before on either checkout is that it
should be called regardless.  On a clobber there can be bad state from either
KVM or the mount points (neither of this rely on the source tree).  If git
cleanup is dependent on having the source tree, than it should special case to
make sure the dir exists.

[davidjames, 2010-11-16 02:05:48]

OK PTAL

[sosa, 2010-11-16 02:08:12]

If understand correctly, this means if there is no checkout ... cros mark clean
will just "skip" all the overlays on a clean?  IF so LGTM

[scottz-goog, 2010-11-16 02:39:02]

If clobber leaves behind bad state then it isn't a proper clobber. Clobber
really should be a "set back to zero"

What state is it leaving behind?

-scott


On Mon, Nov 15, 2010 at 17:51, <sosa@chromium.org> wrote:

> This isn't the right fix.
>
> Clobber can leave some bad state behind that rinse will take care of.  If
> rinse
> can't be run without the src tree than that should be fixed.
>
>
> http://codereview.chromium.org/4988004/
>