Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 4988001: Revert 66088 - Changing the installer switches from wchar_t[] to char[].... (Closed)

Created:
10 years, 1 month ago by tommi (sloooow) - chröme
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org, brettw-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 66088 - Changing the installer switches from wchar_t[] to char[]. Because of this I'm also refactoring some code that before was using wstring to build command lines by hand instead of using the CommandLine class. Now we use CommandLine. To get this to work correctly, I also needed to fix CommandLine::AppendArguments so I added a little test for it. TEST=There should be no changes in functionality. Run all installer tests. BUG=61609 Review URL: http://codereview.chromium.org/4928002 TBR=tommi@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66089

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -201 lines) Patch
M base/command_line.cc View 2 chunks +3 lines, -16 lines 0 comments Download
M base/command_line_unittest.cc View 2 chunks +1 line, -26 lines 0 comments Download
M chrome/browser/browser_main_win.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/installer/setup/install.cc View 3 chunks +28 lines, -19 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M chrome/installer/setup/uninstall.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/setup/uninstall.cc View 2 chunks +12 lines, -8 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M chrome/installer/util/install_util.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/installer/util/install_util.cc View 2 chunks +5 lines, -18 lines 0 comments Download
M chrome/installer/util/master_preferences.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/master_preferences_unittest.cc View 2 chunks +33 lines, -26 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 2 chunks +15 lines, -12 lines 0 comments Download
M chrome/installer/util/util_constants.h View 1 chunk +26 lines, -26 lines 0 comments Download
M chrome/installer/util/util_constants.cc View 4 chunks +27 lines, -27 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tommi (sloooow) - chröme
10 years, 1 month ago (2010-11-15 00:18:10 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698