Chromium Code Reviews

Issue 4985003: Revert 66214 - Display a warning when autofill is disabled for a website.... (Closed)

Created:
10 years, 1 month ago by Ilya Sherman
Modified:
9 years, 7 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org, James Hawkins, dhollowa
Visibility:
Public.

Description

Revert 66214 - Display a warning when autofill is disabled for a website. This depends on a WebKit change being tracked at https://bugs.webkit.org/show_bug.cgi?id=49291 BUG=58509 TEST=unit_tests --gtest_filter=AutoFillManagerTest.*:AutoFillHelperTest.* Review URL: http://codereview.chromium.org/4591001 TBR=isherman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66220

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+230 lines, -442 lines)
M chrome/app/generated_resources.grd View 2 chunks +1 line, -7 lines 0 comments
M chrome/browser/autocomplete_history_manager.h View 2 chunks +3 lines, -1 line 0 comments
M chrome/browser/autocomplete_history_manager.cc View 4 chunks +14 lines, -10 lines 0 comments
M chrome/browser/autofill/autofill_manager.h View 1 chunk +2 lines, -1 line 0 comments
M chrome/browser/autofill/autofill_manager.cc View 9 chunks +16 lines, -47 lines 0 comments
M chrome/browser/autofill/autofill_manager_unittest.cc View 23 chunks +34 lines, -239 lines 0 comments
M chrome/browser/autofill/form_structure.h View 2 chunks +12 lines, -7 lines 0 comments
M chrome/browser/autofill/form_structure.cc View 6 chunks +50 lines, -5 lines 0 comments
M chrome/browser/autofill/form_structure_unittest.cc View 19 chunks +23 lines, -25 lines 0 comments
MM chrome/browser/renderer_host/render_view_host.h View 2 chunks +7 lines, -9 lines 0 comments
MM chrome/browser/renderer_host/render_view_host.cc View 3 chunks +25 lines, -28 lines 0 comments
MM chrome/browser/renderer_host/render_view_host_delegate.h View 2 chunks +10 lines, -7 lines 0 comments
M chrome/common/render_messages_internal.h View 1 chunk +1 line, -1 line 0 comments
M chrome/renderer/autofill_helper.h View 3 chunks +3 lines, -13 lines 0 comments
M chrome/renderer/autofill_helper.cc View 5 chunks +22 lines, -35 lines 0 comments
M chrome/renderer/form_manager.cc View 2 chunks +7 lines, -7 lines 0 comments

Messages

Total messages: 1 (0 generated)
Ilya Sherman
10 years, 1 month ago (2010-11-16 02:18:16 UTC) #1

          

Powered by Google App Engine