Tabbed options - disable add/edit buttons in content settings lists

chrome/browser/resources/options/content_settings_exceptions_area.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options.contentSettings', function() {
   const List = cr.ui.List;
   const ListItem = cr.ui.ListItem;
   const ArrayDataModel = cr.ui.ArrayDataModel;
 
   /**
@@ skipping 263 matching lines @@
         input.select();
         return;
       }
 
       patternLabel.classList.toggle('hidden');
       settingLabel.classList.toggle('hidden');
       input.classList.toggle('hidden');
       select.classList.toggle('hidden');
 
       var doc = this.ownerDocument;
+
+      var area = document.querySelector('div[contentType=' +

[Mike Mammarella, 2010/11/16 00:00:01]

You should use the doc variable declared just above instead of document.

[Evan Stade, 2010/11/16 01:31:25]

Done.

+          listItem.contentType + '][mode=' + listItem.mode + ']');
+      area.enableAddAndEditButtons(!editing);
+
       if (editing) {
         this.setAttribute('editing', '');
         cr.ui.limitInputWidth(input, this, 20);
         input.focus();
         input.select();
       } else {
         this.removeAttribute('editing');
 
         var newPattern = input.value;
 
@@ skipping 155 matching lines @@
         var addRow = cr.doc.createElement('button');
         addRow.textContent = templateData.addExceptionRow;
         this.appendChild(addRow);
 
         addRow.onclick = function(event) {
           var emptyException = new Object;
           emptyException.displayPattern = '';
           emptyException.setting = '';
           self.exceptionsList.addException(emptyException);
         };
+        this.addRow = addRow;
 
         var editRow = cr.doc.createElement('button');
         editRow.textContent = templateData.editExceptionRow;
         this.appendChild(editRow);
         this.editRow = editRow;
 
         editRow.onclick = function(event) {
           self.exceptionsList.editSelectedRow();
         };
       }
@@ skipping 33 matching lines @@
     set mode(mode) {
       return this.setAttribute('mode', mode);
     },
 
     /**
      * Update the enabled/disabled state of the editing buttons based on which
      * rows are selected.
      */
     updateButtonSensitivity: function() {
       var selectionSize = this.exceptionsList.selectedItems.length;
-      if (this.editRow)
-        this.editRow.disabled = selectionSize != 1;
+      if (this.addRow)
+        this.addRow.disabled = this.addAndEditButtonsDisabled;
+      if (this.editRow) {
+        this.editRow.disabled = selectionSize != 1 ||
+            this.addAndEditButtonsDisabled;
+      }
       this.removeRow.disabled = selectionSize == 0;
     },
 
     /**
+     * Manually toggle the enabled/disabled state for the add and edit buttons.
+     * They'll be disabled while another row is being edited.
+     * @param {boolean}
+     */
+    enableAddAndEditButtons: function(enable) {
+      this.addAndEditButtonsDisabled = !enable;
+      this.updateButtonSensitivity();
+    },
+
+    /**
      * Callback from the selection model.
      * @param {!cr.Event} ce Event with change info.
      * @private
      */
     handleOnSelectionChange_: function(ce) {
       this.updateButtonSensitivity();
    },
   };
 
   return {
     ExceptionsListItem: ExceptionsListItem,
     ExceptionsList: ExceptionsList,
     ExceptionsArea: ExceptionsArea
   };
 });