Issue 4983005: Tabbed options - disable add/edit buttons in content settings lists

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4983005: Tabbed options - disable add/edit buttons in content settings lists (Closed)

Created:
10 years, 1 month ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Mike Mammarella

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Tabbed options - disable add/edit buttons in content settings lists while editing an exception. BUG=62908 TEST=manual committed r66219

Patch Set 2 : use doc without ument #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -2 lines)			Patch
	M	chrome/browser/resources/options/content_settings_exceptions_area.js	View	1	3 chunks	+21 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mike Mammarella

LGTM http://codereview.chromium.org/4983005/diff/1/chrome/browser/resources/options/content_settings_exceptions_area.js File chrome/browser/resources/options/content_settings_exceptions_area.js (right): http://codereview.chromium.org/4983005/diff/1/chrome/browser/resources/options/content_settings_exceptions_area.js#newcode285 chrome/browser/resources/options/content_settings_exceptions_area.js:285: var area = document.querySelector('div[contentType=' + You should use ...

10 years, 1 month ago (2010-11-16 00:00:01 UTC) #2

Evan Stade

10 years, 1 month ago (2010-11-16 01:31:25 UTC) #3

http://codereview.chromium.org/4983005/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/content_settings_exceptions_area.js
(right):

http://codereview.chromium.org/4983005/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/content_settings_exceptions_area.js:285: var
area = document.querySelector('div[contentType=' +
On 2010/11/16 00:00:01, Mike Mammarella wrote:
> You should use the doc variable declared just above instead of document.

Done.

Expand Messages | Collapse Messages

Issue 4983005: Tabbed options - disable add/edit buttons in content settings lists (Closed)

Description

Patch Set 1 #

Patch Set 2 : use doc without ument #

Messages