Allow sync with 2-factor StrongAuth accounts in ChromeOS.

chrome/browser/chromeos/login/login_performer.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/login_performer.h"
 
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browser_thread.h"
 #include "chrome/browser/chromeos/boot_times_loader.h"
 #include "chrome/browser/chromeos/login/login_utils.h"
 #include "chrome/browser/chromeos/user_cros_settings_provider.h"
 #include "chrome/browser/profile.h"
 #include "chrome/browser/profile_manager.h"
 
 namespace chromeos {
 
 namespace {
 }  // namespace
 
 LoginPerformer::LoginPerformer(Delegate* delegate)
     : last_login_failure_(LoginFailure::None()),
       delegate_(delegate) {}
 
 ////////////////////////////////////////////////////////////////////////////////
 // LoginPerformer, LoginStatusConsumer implementation:
 
+void LoginPerformer::SetLoginFailure(const LoginFailure& failure) {
+ last_login_failure_ = failure;
+}
+
 void LoginPerformer::OnLoginFailure(const LoginFailure& failure) {
  last_login_failure_ = failure;
  if (delegate_) {
    captcha_.clear();
    captcha_token_.clear();
    if (failure.reason() == LoginFailure::NETWORK_AUTH_FAILED &&
        failure.error().state() == GoogleServiceAuthError::CAPTCHA_REQUIRED) {
      captcha_token_ = failure.error().captcha().token;
    }
    delegate_->OnLoginFailure(failure);
  } else {
    // TODO(nkostylev): Provide blocking UI using ScreenLocker.
  }
 }
 
 void LoginPerformer::OnLoginSuccess(
     const std::string& username,
     const std::string& password,
     const GaiaAuthConsumer::ClientLoginResult& credentials,
     bool pending_requests) {
   if (delegate_) {
+    if (last_login_failure_.reason() != LoginFailure::NONE)
+      delegate_->SetLoginFailure(last_login_failure_);
     delegate_->OnLoginSuccess(username,
                               password,
                               credentials,
                               pending_requests);
     if (!pending_requests)
       MessageLoop::current()->DeleteSoon(FROM_HERE, this);
   } else {
     DCHECK(!pending_requests);

[Nikita (slow), 2010/11/17 12:07:45]

In R10 we're moving to the case when offline auth is performed first and then
browser is launched, parallel to that online auth is performed.

So this path should be used to open a tab in the currently launching browser
with the URL you're adding in this CL.

See http://codereview.chromium.org/3583013/

[stevenjb, 2010/11/17 23:48:41]

The refactoring based on chris's feedback eliminates the need for this change,
so should at least reduce any conflicts with 3583013, but we will want to test
the new logic with 2-factor strong auth and ensure that the new state is
successfully propagated.

     // Online login has succeeded. Delete our instance.
     MessageLoop::current()->DeleteSoon(FROM_HERE, this);
   }
 }
 
 void LoginPerformer::OnOffTheRecordLoginSuccess() {
   if (delegate_)
     delegate_->OnOffTheRecordLoginSuccess();
   else
     NOTREACHED();
@@ skipping 82 matching lines @@
                         &Authenticator::AuthenticateToLogin,
                         profile,
                         username_,
                         password_,
                         captcha_token_,
                         captcha_));
   password_.clear();
 }
 
 }  // namespace chromeos