Issue 4980004: Fix the ChromeFrame FullTabModeIE_TestDownloadFromForm test flakiness on IE9....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4980004: Fix the ChromeFrame FullTabModeIE_TestDownloadFromForm test flakiness on IE9.... (Closed)

Created:
10 years, 1 month ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
amit

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix the ChromeFrame FullTabModeIE_TestDownloadFromForm test flakiness on IE9. TBR=amit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66311

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome_frame/test/test_with_web_server.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

amit

10 years, 1 month ago (2010-11-16 19:57:08 UTC) #2

ok

On Tue, Nov 16, 2010 at 11:33 AM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Fix the ChromeFrame FullTabModeIE_TestDownloadFromForm test flakiness on
> IE9.
>
> TBR=amit
>
>
> Please review this at http://codereview.chromium.org/4980004/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/test/test_with_web_server.cc
>
>
> Index: chrome_frame/test/test_with_web_server.cc
> ===================================================================
> --- chrome_frame/test/test_with_web_server.cc   (revision 66193)
> +++ chrome_frame/test/test_with_web_server.cc   (working copy)
> @@ -1240,9 +1240,11 @@
>   };
>
>   EXPECT_CALL(win_observer_mock, OnWindowOpen(_))
> +      .Times(testing::AtMost(1))
>       .WillOnce(chrome_frame_test::DoCloseWindow());
>
>   EXPECT_CALL(win_observer_mock, OnWindowClose(_))
> +      .Times(testing::AtMost(1))
>       .WillOnce(QUIT_LOOP(loop_));
>
>   SimpleWebServerTest server(46664);
>
>
>

Expand Messages | Collapse Messages