chrome/test/data/web_app_info/full.json - Issue 4979003: Implement web app definition parsing.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/web_app_info/full.json

Issue 4979003: Implement web app definition parsing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: cleanup Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 {

	2 "name": "hello",

	3 "description": "This app is super awesome",

	4 "launch_url": "launch_url",

	5 "launch_container": "panel",

	6 "privileges": [ "geolocation", "notifications" ],

	7 "urls": [ "foobar", "baz" ],

	8 "icons": {

	9 "ignored": "ignored.png",

	10 "16": "16.png",

	11 // We also ignore this because it is larger than 128.
	Erik does not do reviews 2010/11/15 19:45:36 I thought our JSON parser barfed on comments I thought our JSON parser barfed on comments Aaron Boodman 2010/11/16 03:44:45 The one in v8 does (as per the spec), but the one Show quoted text On 2010/11/15 19:45:36, Erik Kay wrote: > I thought our JSON parser barfed on comments The one in v8 does (as per the spec), but the one that we wrote (in base/json) accepts them, which I think is quite nice. Erik does not do reviews 2010/11/16 23:43:02 agree. that always bugged me about the JSON spec. Show quoted text On 2010/11/16 03:44:45, Aaron Boodman wrote: > On 2010/11/15 19:45:36, Erik Kay wrote: > > I thought our JSON parser barfed on comments > > The one in v8 does (as per the spec), but the one that we wrote (in base/json) > accepts them, which I think is quite nice. agree. that always bugged me about the JSON spec.
	12 "500": "500.png"

	13 }

	14 }

OLD	NEW